Always specify Cache-Control: no-cache in development
#805
Conversation
|
@alxndrsn, just wanted to see if you have time to take a quick look at this! Would be awesome if you could try it out and see if it helps with the issue you saw. I do think that it's an improvement, so part of me thinks that we should merge even if it doesn't end up solving your problem. |
|
I haven't experimented much. I've been using the following for recent dev, but I'm not certain if it fixes issues, or if it's all relevant or necessary: diff --git a/Procfile b/Procfile
index 5a38008a..3a73c6e9 100644
--- a/Procfile
+++ b/Procfile
@@ -1,2 +1,2 @@
-vue: vue-cli-service build --mode development --watch
+vue: vue-cli-service serve
nginx: nginx -c "$PWD/main.nginx.conf" -p "$PWD"
diff --git a/main.nginx.conf b/main.nginx.conf
index 2026811f..ce5c1f7f 100644
--- a/main.nginx.conf
+++ b/main.nginx.conf
@@ -63,12 +63,14 @@ http {
location /- {
proxy_pass http://localhost:8005/-;
+ proxy_cache off;
proxy_redirect off;
proxy_set_header Host $host;
}
location ~ ^/v\d {
proxy_pass http://localhost:8383;
+ proxy_cache off;
proxy_redirect off;
# buffer requests, but not responses, so streaming out works.
@@ -95,12 +97,9 @@ http {
}
location / {
- root ./dist;
-
- location /index.html {
- include ./common-headers.nginx.conf;
- add_header Cache-Control no-cache;
- }
+ proxy_pass http://localhost:5000/;
+ proxy_cache off;
+ proxy_redirect off;
}
}
} |
|
Do you have any objection to the change in this PR? (Does the code look OK?) If it looks fine, I'd be interested to try merging it to see if it solves things. |
|
I don't see any obvious issues with it. Is there any significance to the change in order of |
I don't think so, I've reverted!
We use |
Should we be using |
I agree that
Yeah, it could probably be clearer. 😅 How about:
|
Sometimes in local development, refreshing the page doesn't load the latest Frontend code: the same version of the page is shown as before. That can be especially confusing if the code change isn't visible in the UI, because it's harder to see that the page is outdated. Sometimes hard-refreshing the page doesn't even seem to load the latest code. In that case, I've had to restart
npm run dev.I've encountered this issue, and I know @ktuite and @alxndrsn have as well. Part of what's confusing is that it's not consistent (at least not for me). I can work for a long time without seeing this behavior.
Anecdotally, I feel like I've seen this issue much more since we've moved to Vue 3. Vue CLI isn't the preferred build tool for Vue 3, so I've been thinking that it's some issue with Vue CLI. In that case, the answer would probably be to move to Vite, which we want to do anyway (#671).
However, @ktuite was seeing this behavior even before Vue 3: see #520. Reading that issue, I do think that we need to change the
Cache-Controlheader in development. I'm hoping that will just solve the issue, and that's the change that this PR makes. Even if that change doesn't fix things, we'll know more afterwards. I certainly don't think this change will hurt anything.Another anecdote: I think I've seen this behavior most often for files in the main bundle. Whenever I modify src/router.js, it's fairly common for the change not to show up right away. However, most of the time, I'm working on components and files that components import, for example, composables and files in src/util/, and I feel like I see this issue much less often then. Most components are loaded asynchronously, which might have something to do with it. @alxndrsn reports having seen this issue while working on a component. However, the component he was working on,
AccountLogin, is part of the main bundle, which seems consistent with the idea that the main bundle is a primary part of the issue. All that said, I'm pretty sure I've seen this issue outside the main bundle, just much less often (but more often now than with Vue 2).There are other strategies we could try if this PR doesn't work. However, I think this is a good first step.
It's hard to know how to verify this PR given that I encounter the issue inconsistently. @alxndrsn, how consistently do you encounter the issue? Could you try out this PR and see if it helps? One thing I have verified is that
Cache-Controlis returned asno-cachefor a range of Frontend files, not just index.html.